Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Unskip linting unit test by making it work with python3" #22413

Merged
merged 2 commits into from Mar 24, 2020

Conversation

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Mar 24, 2020

Reverts #21954

The print function is already tested in the test_print_function test below. As long as we support Python 2, we should also have the test_print_statement test for print statements.

This reverts commit b9b3e97.
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-22413 Mar 24, 2020 Inactive
Copy link
Contributor

@stephenmcgruer stephenmcgruer left a comment

Yikes, thanks for catching this!

There are Azure failures which I'll check now.

@stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Mar 24, 2020

Azure failure seems to be Python 3.8 on manifest/tests/test_manifest.py, which this PR doesn't touch (cc @svillar - are you aware of that failure?).

Admin merging this PR.

@stephenmcgruer stephenmcgruer merged commit a1e3c1e into master Mar 24, 2020
29 of 31 checks passed
29 of 31 checks passed
build-and-publish
Details
build-and-tag
Details
detect-deployment
Details
Azure Pipelines Build #20200324.24 had test failures
Details
Azure Pipelines (tools/ unittests: macOS (Python 3.8)) tools/ unittests: macOS (Python 3.8) failed
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows (Python 3.6)) tools/ unittests: Windows (Python 3.6) succeeded
Details
Azure Pipelines (tools/ unittests: Windows (Python 3.8)) tools/ unittests: Windows (Python 3.8) succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS (Python 3.6)) tools/ unittests: macOS (Python 3.6) succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows (Python 3.6)) tools/wpt/ tests: Windows (Python 3.6) succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows (Python 3.8)) tools/wpt/ tests: Windows (Python 3.8) succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS (Python 3.6)) tools/wpt/ tests: macOS (Python 3.6) succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS (Python 3.8)) tools/wpt/ tests: macOS (Python 3.8) succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows (Python 3.6)) tools/wptrunner/ unittests: Windows (Python 3.6) succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows (Python 3.8)) tools/wptrunner/ unittests: Windows (Python 3.8) succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS (Python 3.6)) tools/wptrunner/ unittests: macOS (Python 3.6) succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS (Python 3.8)) tools/wptrunner/ unittests: macOS (Python 3.8) succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
@stephenmcgruer stephenmcgruer deleted the revert-21954-test_file_lints branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants