Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers #22420

Merged
merged 1 commit into from Apr 27, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 24, 2020

This CL adds upgrade-insecure-request wpts to test static-import from
dedicated workers and shared workers.

The test scheme is implemented in the previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2102036.
This CL only removes 'worker-import' and 'sharedworker-import' from
the excluded subresource list in spec.src.json and auto-generates tests.

Bug: 989399
Change-Id: I3b799d7743306a8b5fca0d7292360a88d9b36ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117591
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Cr-Commit-Position: refs/heads/master@{#753164}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2117591 branch from f69f12d to b5657e4 Mar 25, 2020
@Hexcles Hexcles closed this Mar 26, 2020
@Hexcles Hexcles reopened this Mar 26, 2020
@KyleJu
Copy link

KyleJu commented Mar 27, 2020

The following tests are flaky on Chrome Dev.

Test Subtest Results Messages
/upgrade-insecure-requests/gen/top.meta/unset/sharedworker-import.https.html **OK: 9/10, TIME
/upgrade-insecure-requests/gen/top.meta/unset/sharedworker-import.https.html OK: 9/10, TIMEOUT: 1/10
/upgrade-insecure-requests/gen/top.meta/unset/sharedworker-import.https.html Upgrade-Insecure-Requests: Expects blocked for sharedworker-import to cross-http-downgrade origin and downgrade redirection from https context. PASS: 9/10, TIMEOUT: 1/10 Test timed out
/upgrade-insecure-requests/gen/top.meta/unset/sharedworker-import.https.html Upgrade-Insecure-Requests: Expects blocked for sharedworker-import to cross-http-downgrade origin and no-redirect redirection from https context. NOTRUN: 1/10, PASS: 9/10
/upgrade-insecure-requests/gen/top.meta/unset/sharedworker-import.https.html Upgrade-Insecure-Requests: Expects blocked for sharedworker-import to cross-https origin and downgrade redirection from https context. NOTRUN: 1/10, PASS: 9/10
/upgrade-insecure-requests/gen/top.meta/unset/sharedworker-import.https.html Upgrade-Insecure-Requests: Expects blocked for sharedworker-import to same-http-downgrade origin and downgrade redirection from https context. NOTRUN: 1/10, PASS: 9/10
/upgrade-insecure-requests/gen/top.meta/unset/sharedworker-import.https.html Upgrade-Insecure-Requests: Expects blocked for sharedworker-import to same-http-downgrade origin and no-redirect redirection from https context. NOTRUN: 1/10, PASS: 9/10
/upgrade-insecure-requests/gen/top.meta/unset/sharedworker-import.https.html Upgrade-Insecure-Requests: Expects blocked for sharedworker-import to same-https origin and downgrade redirection from https context. NOTRUN: 1/10, PASS: 9/10
@KyleJu
Copy link

KyleJu commented Mar 27, 2020

@elkurin Would you mind taking a quick look? Let me know if you need help reproducing it locally!

@elkurin
Copy link
Contributor

elkurin commented Mar 30, 2020

@nhiroki Could you check this? Thanks!

@LukeZielinski
Copy link
Contributor

LukeZielinski commented Mar 31, 2020

Added a ping in the originating CL.

@nhiroki
Copy link
Contributor

nhiroki commented Apr 1, 2020

OK, I'll take a look.

…d workers

This CL adds upgrade-insecure-request wpts to test static-import from
dedicated workers and shared workers.

The test scheme is implemented in the previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2102036.
This CL only removes 'worker-import' and 'sharedworker-import' from
the excluded subresource list in spec.src.json and auto-generates tests.

Bug: 989399
Change-Id: I3b799d7743306a8b5fca0d7292360a88d9b36ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117591
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Cr-Commit-Position: refs/heads/master@{#753164}
@foolip foolip force-pushed the chromium-export-cl-2117591 branch from b5657e4 to 5179406 Apr 27, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 19a0095 into master Apr 27, 2020
10 checks passed
10 checks passed
Azure Pipelines Build #20200427.18 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2117591 branch Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.