Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply adjustments for 'text-anchor' after 'textLength' for <textPath> #22422

Merged
merged 1 commit into from Mar 25, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 24, 2020

When computing the position on the path for 'text-anchor' adjustments,
any potential adjustments performed for 'textLength' needs to be
considered. Previously the adjustment was computed as part of the
summation of the chunk lengths.

Bug: 603995
Change-Id: I579688e9ecf33a17898ecf228de6d44337455ed8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116236
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#753299}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2116236 branch from 35c2c0c to 8025c23 Mar 25, 2020
When computing the position on the path for 'text-anchor' adjustments,
any potential adjustments performed for 'textLength' needs to be
considered. Previously the adjustment was computed as part of the
summation of the chunk lengths.

Bug: 603995
Change-Id: I579688e9ecf33a17898ecf228de6d44337455ed8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116236
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#753299}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2116236 branch from 8025c23 to 083c2c5 Mar 25, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 24959a0 into master Mar 25, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200325.61 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2116236 branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.