Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate activation-gated APIs from user-activation WPTs. #22423

Merged
merged 1 commit into from Mar 30, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 24, 2020

This CL isolates activation-gated APIs from the tests because those API
behavior may depend on other browser-defined things.

Four specific changes done here are:

  • Isolate a basic activation test as non-tentative.
  • Replace an existing wpt with a chained setTimeout test.
  • Isolate tests for same/cross-origin consumption behavior.
  • Clarify tests for same/cross-origin navigation behavior.

Change-Id: I0a7e6d87fc8ed088cd162bbaa8584e8ea7710239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110685
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754529}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2110685 branch from 6699d17 to 587e41d Mar 27, 2020
This CL isolates activation-gated APIs from the tests because those API
behavior may depend on other browser-defined things.

Four specific changes done here are:
- Isolate a basic activation test as non-tentative.
- Replace an existing wpt with a chained setTimeout test.
- Isolate tests for same/cross-origin consumption behavior.
- Clarify tests for same/cross-origin navigation behavior.

Change-Id: I0a7e6d87fc8ed088cd162bbaa8584e8ea7710239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110685
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754529}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2110685 branch from 587e41d to 3823586 Mar 30, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit bb678e5 into master Mar 30, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200330.64 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2110685 branch Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants