Isolate activation-gated APIs from user-activation WPTs. #22423
Merged
Conversation
|
The review process for this patch is being conducted in the Chromium project. |
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-2110685
branch
from
6699d17
to
587e41d
This CL isolates activation-gated APIs from the tests because those API behavior may depend on other browser-defined things. Four specific changes done here are: - Isolate a basic activation test as non-tentative. - Replace an existing wpt with a chained setTimeout test. - Isolate tests for same/cross-origin consumption behavior. - Clarify tests for same/cross-origin navigation behavior. Change-Id: I0a7e6d87fc8ed088cd162bbaa8584e8ea7710239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110685 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#754529}
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-2110685
branch
from
587e41d
to
3823586
chromium-wpt-export-bot
merged commit bb678e5
into
master
13 checks passed
13 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This CL isolates activation-gated APIs from the tests because those API
behavior may depend on other browser-defined things.
Four specific changes done here are:
Change-Id: I0a7e6d87fc8ed088cd162bbaa8584e8ea7710239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110685
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754529}