Add a test for unexpected activation triggered during space keydown driven focus management #22424
Conversation
uievents/order-of-events/focus-events/focus-management-expectations.html
Outdated
Show resolved
Hide resolved
Is this safe to land now? |
@Hexcles Not sure who this question is for, but for what it's worth I've done all I can here. Is there something this needs to wait for? There is this new comment on https://bugzilla.mozilla.org/show_bug.cgi?id=1220143#c12, which I've replied to. |
Thanks, @muan. I'm merging this now. If anyone (including folks on the Bugzilla thread) has further comments, we can always follow up. |
cc87c18
into
web-platform-tests:master
10 checks passed
10 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Relevant spec: https://w3c.github.io/uievents/#event-flow-activation
This is targeting a Firefox bug where when forwarding focus on space and enter keydown events, a unexpected click event is triggered on the forward target.
Here's a demo page for the buggy behavior: https://html-is.glitch.me/firefox-space-focus.html
Since this is my first WPT pull request, I want to keep it small– this test case only cover the Space key case where Firefox is the outlier.
There might be a better place for this test file. I'd be happy to take any suggestions and make changes accordingly.
Many thanks to @Hexcles & @jgraham for helping me in IRC.
Reference re
\ue00d
: https://bugzilla.mozilla.org/show_bug.cgi?id=1417955