Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for unexpected activation triggered during space keydown driven focus management #22424

Merged
merged 5 commits into from Apr 20, 2020

Conversation

@muan
Copy link
Contributor

@muan muan commented Mar 24, 2020

Relevant spec: https://w3c.github.io/uievents/#event-flow-activation

This is targeting a Firefox bug where when forwarding focus on space and enter keydown events, a unexpected click event is triggered on the forward target.

Here's a demo page for the buggy behavior: https://html-is.glitch.me/firefox-space-focus.html

Since this is my first WPT pull request, I want to keep it small– this test case only cover the Space key case where Firefox is the outlier.

There might be a better place for this test file. I'd be happy to take any suggestions and make changes accordingly.

Many thanks to @Hexcles & @jgraham for helping me in IRC.


Reference re \ue00d: https://bugzilla.mozilla.org/show_bug.cgi?id=1417955

…ation
muan added 3 commits Mar 25, 2020
@NavidZ
NavidZ approved these changes Mar 30, 2020
@Hexcles
Copy link
Member

@Hexcles Hexcles commented Apr 16, 2020

Is this safe to land now?

@muan
Copy link
Contributor Author

@muan muan commented Apr 20, 2020

@Hexcles Not sure who this question is for, but for what it's worth I've done all I can here. Is there something this needs to wait for?

There is this new comment on https://bugzilla.mozilla.org/show_bug.cgi?id=1220143#c12, which I've replied to.

@Hexcles
Copy link
Member

@Hexcles Hexcles commented Apr 20, 2020

Thanks, @muan. I'm merging this now. If anyone (including folks on the Bugzilla thread) has further comments, we can always follow up.

@Hexcles Hexcles merged commit cc87c18 into web-platform-tests:master Apr 20, 2020
10 checks passed
10 checks passed
Azure Pipelines Build #20200327.73 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@muan muan deleted the muan:keydown branch Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants