Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox] Migrate column-flex-child-with-overflow-scroll.html to WPT #22425

Merged
merged 1 commit into from Mar 24, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 24, 2020

This CL moves css3/flexbox/column-flex-child-with-overflow-scroll.html
to WPT directory. The test itself ensures the 'height' of flex children
with 'overflow: scroll' do not shrink (commonly by the size of the
scrollbar height).

Original CL: https://codereview.chromium.org/417153003

BUG=1063749
R=dgrogan@chromium.org, robertma@chromium.org

Change-Id: I30d1893d4d75125f68bb7b8daddb848597703ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118631
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#753024}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

This CL moves css3/flexbox/column-flex-child-with-overflow-scroll.html
to WPT directory. The test itself ensures the 'height' of flex children
with 'overflow: scroll' do not shrink (commonly by the size of the
scrollbar height).

Original CL: https://codereview.chromium.org/417153003

BUG=1063749
R=dgrogan@chromium.org, robertma@chromium.org

Change-Id: I30d1893d4d75125f68bb7b8daddb848597703ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118631
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#753024}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2118631 branch from c7af63c to e5d0582 Mar 24, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 02f02cb into master Mar 24, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200324.62 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2118631 branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants