[css-flexbox] Migrate column-flex-child-with-overflow-scroll.html to WPT #22425
Conversation
|
The review process for this patch is being conducted in the Chromium project. |
This CL moves css3/flexbox/column-flex-child-with-overflow-scroll.html to WPT directory. The test itself ensures the 'height' of flex children with 'overflow: scroll' do not shrink (commonly by the size of the scrollbar height). Original CL: https://codereview.chromium.org/417153003 BUG=1063749 R=dgrogan@chromium.org, robertma@chromium.org Change-Id: I30d1893d4d75125f68bb7b8daddb848597703ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118631 Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#753024}
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-2118631
branch
from
c7af63c
to
e5d0582
chromium-wpt-export-bot
merged commit 02f02cb
into
master
13 checks passed
13 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This CL moves css3/flexbox/column-flex-child-with-overflow-scroll.html
to WPT directory. The test itself ensures the 'height' of flex children
with 'overflow: scroll' do not shrink (commonly by the size of the
scrollbar height).
Original CL: https://codereview.chromium.org/417153003
BUG=1063749
R=dgrogan@chromium.org, robertma@chromium.org
Change-Id: I30d1893d4d75125f68bb7b8daddb848597703ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118631
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#753024}