Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-flake image-loading-subpixel-clip.html #22444

Merged
merged 1 commit into from Mar 25, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 25, 2020

If the image is in cache, then the onload handler could happen
synchronously before the script had a time to add the handler.

The fix is to set the src after the onload handler has been registered.

Change-Id: I8586119c5b36f033f36a594cd021230cb8a2bb8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119634
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753318}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

If the image is in cache, then the onload handler could happen
synchronously before the script had a time to add the handler.

The fix is to set the src after the onload handler has been registered.

Change-Id: I8586119c5b36f033f36a594cd021230cb8a2bb8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119634
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753318}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2119634 branch from 74d1c61 to cfa1441 Mar 25, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit cc7aa41 into master Mar 25, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200325.65 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@Hexcles Hexcles deleted the chromium-export-cl-2119634 branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.