Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox] Migrate content-height-with-scrollbars.html to WPT #22445

Merged
merged 1 commit into from Mar 25, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 25, 2020

Original patch: https://bugs.webkit.org/show_bug.cgi?id=92667

BUG=1063749
R=dgrogan@chromium.org, robertma@chromium.org

Change-Id: Ie6d3152184e6c944e0657df1b9ed5fd2364cfa2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120853
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753356}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2120853 branch 2 times, most recently from 14bcfda to 8a3dea7 Mar 25, 2020
Original patch: https://bugs.webkit.org/show_bug.cgi?id=92667

BUG=1063749
R=dgrogan@chromium.org, robertma@chromium.org

Change-Id: Ie6d3152184e6c944e0657df1b9ed5fd2364cfa2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120853
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753356}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2120853 branch from 8a3dea7 to 5006f06 Mar 25, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit b7b2774 into master Mar 25, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200325.72 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2120853 branch Mar 25, 2020
@dholbert
Copy link
Contributor

@dholbert dholbert commented Mar 31, 2020

This WPT test mistakenly assumes/expects that scrollbars occupy space -- but they don't, if they're overlay-style. So the test fails in both Firefox and Chrome on Android (at least). Here are links that you can use to see this yourself:
http://wpt.live/css/css-flexbox/content-height-with-scrollbars.html
http://wpt.live/css/css-flexbox/reference/content-height-with-scrollbars-ref.html

See https://bugzilla.mozilla.org/show_bug.cgi?id=1626212#c2 for more details/analysis.

Not sure what the best course of action is here (backing out vs. leaving it in and annotating it as failing on platforms with overlay scrollbars)... Just posting here as an FYI for now.

@dholbert
Copy link
Contributor

@dholbert dholbert commented Mar 31, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.