Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust Tokens: Add an XMLHttpRequest interface #22451

Merged
merged 1 commit into from Apr 1, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 25, 2020

The experimental Trust Token API
(https://github.com/wicg/trust-token-api)
takes in parameters specifying a Trust Tokens protocol operation,
annotates outgoing requests with request headers corresponding to
protocol state, and processes corresponding response headers. For the
MVP of the API, we're making the functionality available via Fetch,
iframe, and XHR.

To implement the XHR surface, this CL adds a new XHR setter,
that accepts a trustToken object (identical to the one for the Fetch
interface added in crrev.com/c/2036648) specifying a Trust Tokens
operation to execute against the request.

propagated correctly from the XHR interface to the network stack.

Test: Expands integration tests to ensure Trust Tokens params are
Bug: 1062395
Change-Id: I5f32d60c7b59002e79dc877719ba549ce5b9f412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120266
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755369}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2120266 branch 2 times, most recently from 66c732a to 195e4c5 Mar 26, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2120266 branch from 195e4c5 to 8fd0432 Apr 1, 2020
The experimental Trust Token API
(https://github.com/wicg/trust-token-api)
takes in parameters specifying a Trust Tokens protocol operation,
annotates outgoing requests with request headers corresponding to
protocol state, and processes corresponding response headers. For the
MVP of the API, we're making the functionality available via Fetch,
iframe, and XHR.

To implement the XHR surface, this CL adds a new XHR setter,
that accepts a trustToken object (identical to the one for the Fetch
interface added in crrev.com/c/2036648) specifying a Trust Tokens
operation to execute against the request.

propagated correctly from the XHR interface to the network stack.

Test: Expands integration tests to ensure Trust Tokens params are
Bug: 1062395
Change-Id: I5f32d60c7b59002e79dc877719ba549ce5b9f412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120266
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755369}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2120266 branch from 8fd0432 to d766c93 Apr 1, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 605c141 into master Apr 1, 2020
13 checks passed
13 checks passed
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20200401.84 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2120266 branch Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.