Trust Tokens: Add an XMLHttpRequest interface #22451
Merged
Conversation
The review process for this patch is being conducted in the Chromium project. |
66c732a
to
195e4c5
195e4c5
to
8fd0432
The experimental Trust Token API (https://github.com/wicg/trust-token-api) takes in parameters specifying a Trust Tokens protocol operation, annotates outgoing requests with request headers corresponding to protocol state, and processes corresponding response headers. For the MVP of the API, we're making the functionality available via Fetch, iframe, and XHR. To implement the XHR surface, this CL adds a new XHR setter, that accepts a trustToken object (identical to the one for the Fetch interface added in crrev.com/c/2036648) specifying a Trust Tokens operation to execute against the request. propagated correctly from the XHR interface to the network stack. Test: Expands integration tests to ensure Trust Tokens params are Bug: 1062395 Change-Id: I5f32d60c7b59002e79dc877719ba549ce5b9f412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120266 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#755369}
8fd0432
to
d766c93
605c141
into
master
13 checks passed
13 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The experimental Trust Token API
(https://github.com/wicg/trust-token-api)
takes in parameters specifying a Trust Tokens protocol operation,
annotates outgoing requests with request headers corresponding to
protocol state, and processes corresponding response headers. For the
MVP of the API, we're making the functionality available via Fetch,
iframe, and XHR.
To implement the XHR surface, this CL adds a new XHR setter,
that accepts a trustToken object (identical to the one for the Fetch
interface added in crrev.com/c/2036648) specifying a Trust Tokens
operation to execute against the request.
propagated correctly from the XHR interface to the network stack.
Test: Expands integration tests to ensure Trust Tokens params are
Bug: 1062395
Change-Id: I5f32d60c7b59002e79dc877719ba549ce5b9f412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120266
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755369}