Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text] Following up on #22309 #22458

Merged
merged 1 commit into from Apr 10, 2020
Merged

Conversation

@frivoal
Copy link
Contributor

frivoal commented Mar 26, 2020

As discussed in #22309 (comment)

@frivoal frivoal requested a review from litherum Mar 26, 2020
@frivoal frivoal self-assigned this Mar 26, 2020
Copy link
Collaborator

wpt-pr-bot left a comment

@litherum
Copy link
Contributor

litherum commented Mar 26, 2020

Sorry for being ignorant, but how does a test advertise that it is a “should”-level test?

@frivoal
Copy link
Contributor Author

frivoal commented Mar 27, 2020

how does a test advertise that it is a “should”-level test?

<meta name="flags" content="should">

Documented here: https://web-platform-tests.org/writing-tests/css-metadata.html#requirement-flags

I believe this is not (yet) taken into account by wpt.fyi, but it is by testharness.

@frivoal frivoal force-pushed the frivoal:followup-22309 branch from f0985df to 63146b2 Apr 10, 2020
@frivoal frivoal merged commit 8450219 into web-platform-tests:master Apr 10, 2020
10 checks passed
10 checks passed
Azure Pipelines Build #20200410.11 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@frivoal frivoal deleted the frivoal:followup-22309 branch Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.