Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1611848] Properly suppress shadow dom / display: contents inside svg text. #22467

Merged
merged 1 commit into from Mar 27, 2020

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Mar 26, 2020

Returning null from FindSVGData just means "fall back to whatever display
specifies", and that's not great.

Differential Revision: https://phabricator.services.mozilla.com/D67706

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1611848
gecko-commit: 02c284defc4d5f8d9ed1c7c8363becdd93f4b291
gecko-integration-branch: autoland
gecko-reviewers: heycam

Returning null from FindSVGData just means "fall back to whatever display
specifies", and that's not great.

Differential Revision: https://phabricator.services.mozilla.com/D67706

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1611848
gecko-commit: 02c284defc4d5f8d9ed1c7c8363becdd93f4b291
gecko-integration-branch: autoland
gecko-reviewers: heycam
Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Firefox project.

@jgraham jgraham merged commit 87b887c into master Mar 27, 2020
10 of 11 checks passed
10 of 11 checks passed
Community-TC (pull_request) TaskGroup: failure
Details
Azure Pipelines Build #20200326.31 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
upstream/gecko Landed on mozilla-central
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@jgraham jgraham deleted the gecko/1611848 branch Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.