CookieStore: Add validation behavior for __Host- prefixed cookies #23026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 16, 2020
This change adds the following checks for "__Host-" prefixed cookies: 1. Disallows overwriting with an explicit domain 2. Disallows non "/" path This behavior is mentioned in the spec here [1]. Creating a cookie that violates this will cause a crash without this change. [1] https://wicg.github.io/cookie-store/#prefixes Change-Id: I20968f11759019921aa7a6b37602878a17b091ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151825 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#760776}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2151825
branch
from
87cb026
to
4733437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the following checks for "__Host-" prefixed cookies:
This behavior is mentioned in the spec here [1].
Creating a cookie that violates this will cause a crash without
this change.
[1] https://wicg.github.io/cookie-store/#prefixes
Change-Id: I20968f11759019921aa7a6b37602878a17b091ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151825
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760776}