Update Storage Access API Logic & E2E Tests #23515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 11, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2194905
branch
4 times, most recently
from
afa8d71
to
e5c66d4
Compare
This change updates the logic used in the Blink document for document.hasStorageAccess and document.requestStorageAccess. Gates have been added to ensure the proper restrictions such as having a non-opaque origin, sandbox token (if applicable), as well as ensuring that hasStorageAccess reflects the actual state of storage access on the page. Additionally defense in depth logic checks have been added in StorageAccessGrantPermissionContext to shortcut if we get a request for a scenario no grant would be needed. Some additional cleanup is included with this change to remove the temporary usage of CONTENT_SETTING_SESSION in StorageAccessGrantPermissionContext and to ensure all content settings updates will propagate to the network service. A follow up change will ensure this does not result in duplicate updates when we perform our initial update. Browser tests have been added to validate end to end functionality. Bug: 989663 Change-Id: I09fdc115a30a71e341961b385a2e2e05fd161536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194905 Reviewed-by: Maksim Orlovich <morlovich@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Brandon Maslen <brandm@microsoft.com> Cr-Commit-Position: refs/heads/master@{#769847}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2194905
branch
from
e5c66d4
to
41fd1c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the logic used in the Blink document for
document.hasStorageAccess and document.requestStorageAccess. Gates have
been added to ensure the proper restrictions such as having a non-opaque
origin, sandbox token (if applicable), as well as ensuring that
hasStorageAccess reflects the actual state of storage access on the page.
Additionally defense in depth logic checks have been added in
StorageAccessGrantPermissionContext to shortcut if we get a request for
a scenario no grant would be needed.
Some additional cleanup is included with this change to remove the
temporary usage of CONTENT_SETTING_SESSION in
StorageAccessGrantPermissionContext and to ensure all content settings
updates will propagate to the network service. A follow up change will
ensure this does not result in duplicate updates when we perform our
initial update.
Browser tests have been added to validate end to end functionality.
Bug: 989663
Change-Id: I09fdc115a30a71e341961b385a2e2e05fd161536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194905
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Brandon Maslen <brandm@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#769847}