Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1584890] Part 1 - Use nsFrameConstructorState::AddChild() to construct out-of-flow flex or grid container as the root element. #23720

Merged
merged 2 commits into from May 23, 2020

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented May 20, 2020

If contentFrame is out-of-flow, nsFrameConstructorState::AddChild() can
construct a placeholder frame for contentFrame and put the placeholder in
frameList.

Also, we need to use nsFrameConstructorState::GetGeometricParent() to
get the correct parent when calling InitAndRestoreFrame() for an
out-of-flow contentFrame. For example, if contentFrame has
position:fixed, its parent should be ViewportFrame, not
CanvasFrame (which is mDocElementContainingBlock).

This patch also adds reftests for position:absolute flex & grid root
element. Reftests for position:fixed root element are in the next part.

Differential Revision: https://phabricator.services.mozilla.com/D76205

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1584890
gecko-commit: 84d138356c7699456abf8dc6483b1d49aab86771
gecko-integration-branch: autoland
gecko-reviewers: dholbert

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Firefox project.

aethanyc added 2 commits May 22, 2020
…flow flex or grid container as the root element.

If `contentFrame` is out-of-flow, nsFrameConstructorState::AddChild() can
construct a placeholder frame for `contentFrame` and put the placeholder in
`frameList`.

Also, we need to use nsFrameConstructorState::GetGeometricParent() to
get the correct parent when calling InitAndRestoreFrame() for an
out-of-flow `contentFrame`. For example, if `contentFrame` has
position:fixed, its parent should be ViewportFrame, not
CanvasFrame (which is mDocElementContainingBlock).

This patch also adds reftests for position:absolute flex & grid root
element. Reftests for position:fixed root element are in the next part.

Differential Revision: https://phabricator.services.mozilla.com/D76205

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1584890
gecko-commit: 19b910256abfe62d1fcb177e48ed1c1a28f5b2ab
gecko-integration-branch: autoland
gecko-reviewers: dholbert
Differential Revision: https://phabricator.services.mozilla.com/D76206

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1584890
gecko-commit: a00f71376ad18b3cde3d92b338b5304c7ffd7334
gecko-integration-branch: autoland
gecko-reviewers: dholbert
@moz-wptsync-bot moz-wptsync-bot force-pushed the gecko/1584890 branch from 8701bd9 to 3372086 May 22, 2020
@moz-wptsync-bot moz-wptsync-bot merged commit be4a903 into master May 23, 2020
11 checks passed
11 checks passed
Azure Pipelines Build #20200522.30 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
upstream/gecko Landed on mozilla-central
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1584890 branch May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.