Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ImageBitmap's colorSpaceConversion srgb/p3/rec2020 options #23745

Merged
merged 1 commit into from May 25, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented May 23, 2020

There exist standard colorSpaceConversion options of none (ignore
color space) and default (use color space). Specifying srgb, p3, or
rec2020 here is not appropriate. A more appropriate place would
be in ImageData (where there do exist canvas color space parameters).

Bug: 1083693
Change-Id: I3741454c36a59b3c8d679ec843aa05cebcc9d9c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213777
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771609}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

There exist standard colorSpaceConversion options of none (ignore
color space) and default (use color space). Specifying srgb, p3, or
rec2020 here is not appropriate. A more appropriate place would
be in ImageData (where there do exist canvas color space parameters).

Bug: 1083693
Change-Id: I3741454c36a59b3c8d679ec843aa05cebcc9d9c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213777
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771609}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2213777 branch from 79bf48c to c6ffe5c May 25, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f11097e into master May 25, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200525.24 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2213777 branch May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.