Ensure cloning a template element into an inactive document does not crash. #24044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 8, 2020
…crash. Bug: 1092047 Test: html/semantics/scripting-1/the-template-element/template-element/template-element-clone-into-inactive-document-crash.html Change-Id: I7d515c25294fe661781d14d53053dbf1d3be49f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236245 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#776274}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2236245
branch
from
d13ffac
to
ffa7fd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: 1092047
Test: html/semantics/scripting-1/the-template-element/template-element/template-element-clone-into-inactive-document-crash.html
Change-Id: I7d515c25294fe661781d14d53053dbf1d3be49f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236245
Auto-Submit: Nate Chapin <japhet@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776274}