[AspectRatio] Add tests for intrinsic sizes with aspect-ratio #24076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 9, 2020
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2238359
branch
from
c525047
to
045595d
Compare
This adds the test case from https://crrev.com/c/2225827/5#message-a1b578693dd644b88f311c33833fd97254331706 It also adds a test for w3c/csswg-drafts#5032 and some other cases, and exposes a bug I wasn't aware of yet, https://crbug.com/1093094 R=ikilpatrick@chromium.org Bug: 1045668, 1093094 Change-Id: Ib4f76f05edffde99d8d8448c503775469e7da34a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238359 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#777155}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2238359
branch
from
045595d
to
6c012c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the test case from
https://crrev.com/c/2225827/5#message-a1b578693dd644b88f311c33833fd97254331706
It also adds a test for w3c/csswg-drafts#5032
and some other cases, and exposes a bug I wasn't aware of yet,
https://crbug.com/1093094
R=ikilpatrick@chromium.org
Bug: 1045668, 1093094
Change-Id: Ib4f76f05edffde99d8d8448c503775469e7da34a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238359
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777155}