Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interfaces/intervention-reporting.idl and test #24202

Merged
merged 1 commit into from Jul 10, 2020

Conversation

@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Jun 17, 2020

Closes #24193

@wpt-pr-bot wpt-pr-bot requested a review from foolip Jun 17, 2020
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24202 Jun 17, 2020 Inactive
@foolip
Copy link
Member

foolip commented Jun 24, 2020

Per https://wpt.fyi/results/intervention-reporting?sha=bbfa81ff2b&label=pr_head no implementation supports any of this. Is this intended to be exposed to the web?

@stephenmcgruer
Copy link
Contributor Author

stephenmcgruer commented Jun 24, 2020

Is this intended to be exposed to the web?

cc @clelland for this question

@stephenmcgruer stephenmcgruer force-pushed the idlharness-intervention-reporting branch from bbfa81f to 821adbd Jul 9, 2020
@clelland
Copy link
Contributor

clelland commented Jul 9, 2020

Chromium's IDL has this marked as NoInterfaceObject, so that's not exposed. That's been deprecated in WebIDL though, so we should probably remove that attribute.

Objects of this type are web-exposed; they're what you'd see as the body attribute of an intervention report delivered via a reporting observer.

@stephenmcgruer
Copy link
Contributor Author

stephenmcgruer commented Jul 10, 2020

Thanks Ian; we should merge this then and let Chromium fail it until its IDL is fixed.

Ping @foolip for review :)

@foolip
foolip approved these changes Jul 10, 2020
@stephenmcgruer stephenmcgruer merged commit cce6211 into master Jul 10, 2020
20 checks passed
20 checks passed
detect-deployment
Details
Azure Pipelines Build #20200709.51 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@stephenmcgruer stephenmcgruer deleted the idlharness-intervention-reporting branch Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.