Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scroll-animations] Integrate @scroll-timeline with animations #24252

Merged
merged 1 commit into from Jul 10, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jun 19, 2020

Until now it was possible to parse @scroll-timeline rules, but they
did not actually do anything. This CL performs the necessary
integration into StyleEngine and CSSAnimations (partially) to make
something happen.

The applicable StyleRuleScrollTimeline objects are maintained on
StyleEngine. When calculating the animation update, we now take
the animation-timeline property into account, and look for a
rule on StyleEngine corresponding to the specified timeline name.
This rule (if found) then causes a new ScrollTimeline to be created.

This is by no means a fully functional implementation, but it's a
start. The most notable omission is updating timelines, which is
currently not possible (crbug.com/1097053).

Other omissions, flaws, or postponed work are either tracked as
bugs (with TODOs that reference them) or as failing expectations.
This ensures that we don't miss anything before shipping.

Bug: 1074052
Change-Id: I04e75be1dc970ed2f542e60457f8db25bbb0fe7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253752
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787258}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2253752 branch 5 times, most recently from 95a465a to efdf6d4 Jul 7, 2020
Until now it was possible to parse @scroll-timeline rules, but they
did not actually do anything. This CL performs the necessary
integration into StyleEngine and CSSAnimations (partially) to make
something happen.

The applicable StyleRuleScrollTimeline objects are maintained on
StyleEngine. When calculating the animation update, we now take
the animation-timeline property into account, and look for a
rule on StyleEngine corresponding to the specified timeline name.
This rule (if found) then causes a new ScrollTimeline to be created.

This is by no means a fully functional implementation, but it's a
start. The most notable omission is updating timelines, which is
currently not possible (crbug.com/1097053).

Other omissions, flaws, or postponed work are either tracked as
bugs (with TODOs that reference them) or as failing expectations.
This ensures that we don't miss anything before shipping.

Bug: 1074052
Change-Id: I04e75be1dc970ed2f542e60457f8db25bbb0fe7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253752
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787258}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2253752 branch from efdf6d4 to a554c3f Jul 10, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 5fff9da into master Jul 10, 2020
22 checks passed
22 checks passed
Azure Pipelines Build #20200710.69 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2253752 branch Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.