Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wpt/html/coep/require-corp-about-{blank,srcdoc}.html #24392

Merged
merged 1 commit into from Jun 30, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jun 30, 2020

  • platform/mac-mac10.13/.../require-corp-about-blank-expected.txt
    is redundant - it's same as the base expectation.
  • platform/mac-mac10.14/.../require-corp-about-blank-expected.txt
    is wrong - the test always fails on the platform (and the failures
    are suppressed by TestExpectations).
  • wpt/html/coep/require-corp-about-blank.html always fails because
    COEP is only effective on secure contexts
    (whatwg/html#4930). Rename it to
    wpt/html/coep/require-corp-about-blank.https.html
  • wpt/html/coep/require-corp-about-srcdoc.html always fails because
    COEP is only effective on secure contexts
    (whatwg/html#4930). Rename it to
    wpt/html/coep/require-corp-about-srcdoc.https.html
  • Remove redundant TestExpectations entries.

Bug: 1086065, 626703
Change-Id: I5573dd4446f482acdde828404e0a88893897ce09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274133
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#783875}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

 - platform/mac-mac10.13/.../require-corp-about-blank-expected.txt
   is redundant - it's same as the base expectation.
 - platform/mac-mac10.14/.../require-corp-about-blank-expected.txt
   is wrong - the test always fails on the platform (and the failures
   are suppressed by TestExpectations).
 - wpt/html/coep/require-corp-about-blank.html always fails because
   COEP is only effective on secure contexts
   (whatwg/html#4930). Rename it to
   wpt/html/coep/require-corp-about-blank.https.html
 - wpt/html/coep/require-corp-about-srcdoc.html always fails because
   COEP is only effective on secure contexts
   (whatwg/html#4930). Rename it to
   wpt/html/coep/require-corp-about-srcdoc.https.html
 - Remove redundant TestExpectations entries.

Bug: 1086065, 626703
Change-Id: I5573dd4446f482acdde828404e0a88893897ce09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274133
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#783875}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2274133 branch from 635d34b to f441bf0 Jun 30, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f911e67 into master Jun 30, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200630.15 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2274133 branch Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.