Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially revert "Add another https port (#24016)" #24394

Merged
merged 2 commits into from Jun 30, 2020

Conversation

@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Jun 30, 2020

This reverts the change to common/get-host-info.sub.js in commit
95cdf1f.

Adding another HTTPS port broke there broke the Chromium WPT
Importer (as the pinned tooling failed to sub common/get-host-info.sub.js
due to indexing out of bounds).

This reverts commit 95cdf1f.

Adding another HTTPS port broke both wpt.live (as its config no longer
matched the number of ports asserted in wptserve) and the Chromium WPT
Importer (as our pinned tooling failed to sub
common/get-host-info.sub.js due to indexing out of bounds).
Copy link
Member

Hexcles left a comment

LGTM

@stephenmcgruer stephenmcgruer changed the title Revert "Add another https port (#24016)" Partially revert "Add another https port (#24016)" Jun 30, 2020
@stephenmcgruer stephenmcgruer requested a review from Hexcles Jun 30, 2020
@wpt-pr-bot wpt-pr-bot had a problem deploying to wpt-preview-24394 Jun 30, 2020 Error
Copy link
Member

Hexcles left a comment

LGTM

Tangentially, maybe we should make index-out-of-bound non-fatal in templates? But I don't have a great idea how to do that without pushing the error further down the line in a more subtle way.

@stephenmcgruer stephenmcgruer merged commit c9d349e into master Jun 30, 2020
8 of 10 checks passed
8 of 10 checks passed
detect-deployment detect-deployment
Details
Community-TC (pull_request) TaskGroup: failure
Details
wpt.fyi - firefox[experimental] Firefox results
Details
Azure Pipelines Build #20200630.19 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
wpt.fyi - chrome[experimental] Chrome results
Details
@stephenmcgruer stephenmcgruer deleted the smcgruer/revert-https branch Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.