Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSP] Add WPT tests for inheritance with window.open. #24395

Merged
merged 1 commit into from Jul 3, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jun 30, 2020

There are WPT tests about CSP inheritance when opening local-scheme.
This is tested for iframe. Testing for iframes is good, testing for
both iframes and opened window is better.

Initially, I wanted to reproduce bug 1073126, but failed to do so. I
still want to keep the tests.

Bug: chromium:1073126
Change-Id: I4c363037d556bf93f37d43dd5b84a1da608d5e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274602
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785017}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2274602 branch 2 times, most recently from 948ff3d to bc860e8 Jul 2, 2020
There are WPT tests about CSP inheritance when opening local-scheme.
This is tested for iframe. Testing for iframes is good, testing for
both iframes and opened window is better.

Initially, I wanted to reproduce bug 1073126, but failed to do so. I
still want to keep the tests.

Bug: chromium:1073126
Change-Id: I4c363037d556bf93f37d43dd5b84a1da608d5e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274602
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785017}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2274602 branch from bc860e8 to cc55a0d Jul 3, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 51f1241 into master Jul 3, 2020
9 checks passed
9 checks passed
Azure Pipelines Build #20200703.18 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2274602 branch Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.