Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Fix anonymous-block child-available-size. #24396

Merged
merged 1 commit into from Jul 1, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jun 30, 2020

The logic introduced for CalculateChildAvailableSize was designed to
have the correct value for an element with:
"<div style="position: relative; left: 50%; top: 50%;></div>"

E.g. the percentage based left/top would resolve against the available
size. However this broke text alignment within anonymous-blocks which
require the child-available-size to be based on the actual inline-size.

This patch uses the actual inline-size in the inline direction, but
keeps the logic for block direction.

This will mean that for postiion:relative calculations we'll use
the Percentage inline-size, and Available block-size for resolving
percentages.

Bug: 1100203
Change-Id: I83c5281c5de9f9fd40f1bfed54e627dff5bb0600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274359
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784323}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2274359 branch from 9dc028f to df1260e Jun 30, 2020
The logic introduced for CalculateChildAvailableSize was designed to
have the correct value for an element with:
"<div style="position: relative; left: 50%; top: 50%;></div>"

E.g. the percentage based left/top would resolve against the available
size. However this broke text alignment within anonymous-blocks which
require the child-available-size to be based on the actual inline-size.

This patch uses the actual inline-size in the inline direction, but
keeps the logic for block direction.

This will mean that for postiion:relative calculations we'll use
the Percentage inline-size, and Available block-size for resolving
percentages.

Bug: 1100203
Change-Id: I83c5281c5de9f9fd40f1bfed54e627dff5bb0600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274359
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784323}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2274359 branch from df1260e to 4d39914 Jul 1, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 13b2394 into master Jul 1, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200701.8 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2274359 branch Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.