Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert a manual dialog fullscreen test to test_driver #24397

Merged
merged 3 commits into from Jul 3, 2020

Conversation

@sefeng211
Copy link
Contributor

sefeng211 commented Jun 30, 2020

This PR converts the manual dialog fullscreen api test to test_driver.

@sefeng211 sefeng211 requested a review from foolip Jul 2, 2020
@jgraham
jgraham approved these changes Jul 2, 2020
@foolip
foolip approved these changes Jul 3, 2020
Copy link
Member

foolip left a comment

Just one more thing :)

fullscreen/api/element-request-fullscreen-dialog.html Outdated Show resolved Hide resolved
@jgraham jgraham merged commit a2d0588 into web-platform-tests:master Jul 3, 2020
10 checks passed
10 checks passed
Azure Pipelines Build #20200703.20 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.