Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert a manual dialog fullscreen test to test_driver #24397

merged 3 commits into from Jul 3, 2020


Copy link

sefeng211 commented Jun 30, 2020

This PR converts the manual dialog fullscreen api test to test_driver.

@sefeng211 sefeng211 requested a review from foolip Jul 2, 2020
jgraham approved these changes Jul 2, 2020
foolip approved these changes Jul 3, 2020
Copy link

foolip left a comment

Just one more thing :)

fullscreen/api/element-request-fullscreen-dialog.html Outdated Show resolved Hide resolved
@jgraham jgraham merged commit a2d0588 into web-platform-tests:master Jul 3, 2020
10 checks passed
10 checks passed
Azure Pipelines Build #20200703.20 succeeded
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Azure Pipelines ( hook: safari-preview-affected-tests) hook: safari-preview-affected-tests succeeded
Azure Pipelines ( hook: safari-preview-affected-tests-without-changes) hook: safari-preview-affected-tests-without-changes succeeded
Community-TC (pull_request) TaskGroup: success
Details - chrome[experimental] Chrome results
Details - firefox[experimental] Firefox results
Details - safari[experimental] Safari results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.