Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clip state of synthetic effect for non-backdrop effects #24398

Merged
merged 1 commit into from Jun 30, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jun 30, 2020

This fixes a regression caused by crrev.com/c/2183198.
We should move the effect's clip to the outer synthetic effects
for backdrop effects only. For non-backdrop effect we don't move effect
up into the synthetic effect and can share the synthetic effect with
other effects, so we should not move up the clip.

Bug: 1099234
Change-Id: I5dbd63f7c94717e42572342371df6de8fe89308e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272122
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784097}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

This fixes a regression caused by crrev.com/c/2183198.
We should move the effect's clip to the outer synthetic effects
for backdrop effects only. For non-backdrop effect we don't move effect
up into the synthetic effect and can share the synthetic effect with
other effects, so we should not move up the clip.

Bug: 1099234
Change-Id: I5dbd63f7c94717e42572342371df6de8fe89308e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272122
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784097}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2272122 branch from e2a284a to ffb9229 Jun 30, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 716a322 into master Jun 30, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200630.42 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2272122 branch Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.