Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FragmentItem] Include floats in associated LayoutObject #24399

Merged
merged 1 commit into from Jul 1, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jun 30, 2020

This patch changes to associate floating |LayoutObject|s to
|NGFragmentItem| using |FirstInlineFragmentItemIndex|.

The index is used for many purposes, but one of them is to
mark destroyed or moved |LayoutObject| in |NGFragmentItem|.
Because floating objects are stored in |NGFragmentItem|,
they need to be indexed to mark correctly.

Also changes |LayoutBlockFlow::
SetShouldDoFullPaintInvalidationForFirstLine| to skip items
for destroyed or moved |LayoutObject| because it may be
called on dirty tree.

Bug: 1100900
Change-Id: If35bf2c77b9a46a9ba598e6785926f6b0e1c5455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275373
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784297}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2275373 branch 2 times, most recently from e433776 to 0de95b5 Jun 30, 2020
This patch changes to associate floating |LayoutObject|s to
|NGFragmentItem| using |FirstInlineFragmentItemIndex|.

The index is used for many purposes, but one of them is to
mark destroyed or moved |LayoutObject| in |NGFragmentItem|.
Because floating objects are stored in |NGFragmentItem|,
they need to be indexed to mark correctly.

Also changes |LayoutBlockFlow::
SetShouldDoFullPaintInvalidationForFirstLine| to skip items
for destroyed or moved |LayoutObject| because it may be
called on dirty tree.

Bug: 1100900
Change-Id: If35bf2c77b9a46a9ba598e6785926f6b0e1c5455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275373
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784297}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2275373 branch from 0de95b5 to 10c8777 Jul 1, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e5fea0a into master Jul 1, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200701.5 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2275373 branch Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.