Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct StyleResolver in StyleEngine constructor. #24454

Merged
merged 1 commit into from Jul 10, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jul 6, 2020

Years ago, the StyleResolver was deleted and re-created for certain
style sheet changes. The current lifetime of the StyleResolver is that it
is created once on first EnsureStyleResolver and only freed when the
StyleEngine is disposed. Instead of checking if it needs to be
constructed every time we access it, create it as part of constructing
the StyleEngine.

We don't create it for documents without a Frame for which we should not
use the StyleResolver.

Change-Id: I1f1d2ef322d2599737f584191550f769dcf6828e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270209
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787158}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2270209 branch 2 times, most recently from 4455fda to 7a18f8f Jul 8, 2020
Years ago, the StyleResolver was deleted and re-created for certain
style sheet changes. The current lifetime of the StyleResolver is that it
is created once on first EnsureStyleResolver and only freed when the
StyleEngine is disposed. Instead of checking if it needs to be
constructed every time we access it, create it as part of constructing
the StyleEngine.

We don't create it for documents without a Frame for which we should not
use the StyleResolver.

Change-Id: I1f1d2ef322d2599737f584191550f769dcf6828e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270209
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787158}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2270209 branch from 7a18f8f to b80305f Jul 10, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit bfe92da into master Jul 10, 2020
23 checks passed
23 checks passed
Azure Pipelines Build #20200710.41 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
update-built Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2270209 branch Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.