Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlexNG] Fix % max-height definiteness #24527

Merged
merged 1 commit into from Jul 10, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jul 9, 2020

A replaced element's % max-height was being ignored when it was the
child of a flex item that acquired its definite height by stretching.

This was flaky though, it only broke when the image was loaded before
the flexbox had laid out. If the flexbox was laid out, then the image
loaded and hence caused a relayout, the image would obey the
definiteness that was cached from the flex item's first layout.

Change-Id: I2b429aed111a1b800311287337f951c15fcc72f2
Fixed: 1092934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287370
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787095}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2287370 branch from 23c371a to ac0c537 Jul 10, 2020
A replaced element's % max-height was being ignored when it was the
child of a flex item that acquired its definite height by stretching.

This was flaky though, it only broke when the image was loaded before
the flexbox had laid out. If the flexbox was laid out, _then_ the image
loaded and hence caused a relayout, the image would obey the
definiteness that was cached from the flex item's first layout.

Change-Id: I2b429aed111a1b800311287337f951c15fcc72f2
Fixed: 1092934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287370
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787095}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2287370 branch from ac0c537 to 69ae554 Jul 10, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 8e1b09f into master Jul 10, 2020
22 checks passed
22 checks passed
Azure Pipelines Build #20200710.27 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2287370 branch Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.