Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add paint_invalidation_container in PrePaintTreeWalk. #24550

Merged
merged 1 commit into from Jul 10, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jul 10, 2020

This is needed in order to make sure to call
SetNeedsCheckRasterInvalidation() on all GraphicsLayers that
need raster invalidation after an invalidation of paint. To do
this involves finding out into which GraphicsLayer a LayoutObject paints.

We'll be able to remove it in favor of a dirty bit on
CompositingLayerAssigner when pre-paint is moved before compositing.

Bug: 1102733

Change-Id: I506d7e574e802502d9414ad67f14f0d4c072b184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290547
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787058}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2290547 branch from 0dfd8d7 to 44611f8 Jul 10, 2020
This is needed in order to make sure to call
SetNeedsCheckRasterInvalidation() on all GraphicsLayers that
need raster invalidation after an invalidation of paint. To do
this involves finding out into which GraphicsLayer a LayoutObject paints.

We'll be able to remove it in favor of a dirty bit on
CompositingLayerAssigner when pre-paint is moved before compositing.

Bug: 1102733

Change-Id: I506d7e574e802502d9414ad67f14f0d4c072b184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290547
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787058}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2290547 branch from 44611f8 to 94d4172 Jul 10, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e67f139 into master Jul 10, 2020
22 checks passed
22 checks passed
Azure Pipelines Build #20200710.18 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2290547 branch Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.