Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Taskcluster] Make lint create a GitHub Checks output file #24556

Merged
merged 5 commits into from Sep 9, 2020

Conversation

@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Jul 10, 2020

See #15412

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 Jul 10, 2020 Inactive
Copy link
Contributor

jgraham left a comment

Super excited to see this happening!

tools/ci/tc/decision.py Outdated Show resolved Hide resolved
tools/lint/lint.py Outdated Show resolved Hide resolved
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 Jul 28, 2020 Inactive
@stephenmcgruer stephenmcgruer force-pushed the lint-output-md branch from f25a19c to 0ed844a Aug 4, 2020
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 Aug 4, 2020 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 Aug 4, 2020 Inactive
@stephenmcgruer stephenmcgruer force-pushed the lint-output-md branch from b1a7262 to 1bbee29 Aug 4, 2020
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 Aug 4, 2020 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 Aug 5, 2020 Inactive
@stephenmcgruer stephenmcgruer force-pushed the lint-output-md branch from b01accf to 7f8a9e6 Aug 5, 2020
@stephenmcgruer stephenmcgruer marked this pull request as ready for review Aug 5, 2020
@stephenmcgruer stephenmcgruer changed the title [WIP] Make lint spit out GitHub CheckRun output file [Taskcluster] Make lint create a GitHub Checks output file Aug 5, 2020
@stephenmcgruer stephenmcgruer requested a review from jgraham Aug 5, 2020
@stephenmcgruer
Copy link
Contributor Author

stephenmcgruer commented Aug 5, 2020

Ok, this is ready for review. The MyPy types aren't great, but I'm not 100% happy with the code anyway (seems a bit bolted-on) so didn't want to over-invest in fixing them until we are sure this is the right approach.

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 Aug 5, 2020 Inactive
tools/ci/tc/github_checks_output.py Outdated Show resolved Hide resolved
tools/lint/lint.py Outdated Show resolved Hide resolved
tools/lint/lint.py Show resolved Hide resolved
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 Aug 14, 2020 Inactive
@wpt-pr-bot wpt-pr-bot had a problem deploying to wpt-preview-24556 Aug 14, 2020 Error
@stephenmcgruer stephenmcgruer force-pushed the lint-output-md branch from d42d22d to c2b193a Aug 14, 2020
@stephenmcgruer stephenmcgruer requested a review from Hexcles Aug 14, 2020
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 Aug 14, 2020 Inactive
Copy link
Member

Hexcles left a comment

LGTM % a nit

tools/ci/tc/github_checks_output.py Show resolved Hide resolved
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 Aug 14, 2020 Inactive
@stephenmcgruer stephenmcgruer force-pushed the lint-output-md branch from c1cfde5 to 4080216 Aug 17, 2020
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 Aug 17, 2020 Inactive
@stephenmcgruer stephenmcgruer requested a review from Hexcles Aug 20, 2020
@stephenmcgruer
Copy link
Contributor Author

stephenmcgruer commented Aug 31, 2020

Ping @Hexcles @jgraham for re-review.

@jgraham
jgraham approved these changes Sep 7, 2020
Copy link
Contributor

jgraham left a comment

r+ with nits (notably reverting the example change, and a comment for the Any usage).

dom/interface-objects.html Outdated Show resolved Hide resolved
@stephenmcgruer stephenmcgruer merged commit 8420fdf into master Sep 9, 2020
49 of 51 checks passed
49 of 51 checks passed
build-and-publish
Details
build-and-tag
Details
detect-deployment
Details
Azure Pipelines Build #20200909.31 had test failures
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows failed
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows + Python 3.6) tools/ unittests: Windows + Python 3.6 succeeded
Details
Azure Pipelines (tools/ unittests: Windows + Python 3.8) tools/ unittests: Windows + Python 3.8 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS + Python 3.6) tools/ unittests: macOS + Python 3.6 succeeded
Details
Azure Pipelines (tools/ unittests: macOS + Python 3.8) tools/ unittests: macOS + Python 3.8 succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows + Python 3.6) tools/wpt/ tests: Windows + Python 3.6 succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows + Python 3.8) tools/wpt/ tests: Windows + Python 3.8 succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS + Python 3.6) tools/wpt/ tests: macOS + Python 3.6 succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS + Python 3.8) tools/wpt/ tests: macOS + Python 3.8 succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows + Python 3.6) tools/wptrunner/ unittests: Windows + Python 3.6 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows + Python 3.8) tools/wptrunner/ unittests: Windows + Python 3.8 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS + Python 3.6) tools/wptrunner/ unittests: macOS + Python 3.6 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS + Python 3.8) tools/wptrunner/ unittests: macOS + Python 3.8 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
infrastructure/ tests Community-TC (pull_request)
Details
infrastructure/ tests (Python 3) Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
resources/ tests Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
tools/ integration tests (Python 2) Community-TC (pull_request)
Details
tools/ integration tests (Python 3.6) Community-TC (pull_request)
Details
tools/ integration tests (Python 3.8) Community-TC (pull_request)
Details
tools/ unittests (Python 2) Community-TC (pull_request)
Details
tools/ unittests (Python 3.6) Community-TC (pull_request)
Details
tools/ unittests (Python 3.8) Community-TC (pull_request)
Details
update-built Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@stephenmcgruer stephenmcgruer deleted the lint-output-md branch Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.