Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that BroadcastChannel settings object is current, not incumbent #24568

Merged
merged 2 commits into from Jul 14, 2020

Conversation

@domenic
Copy link
Member

domenic commented Jul 10, 2020

Similar to #24566, but tests what origin is used for message-delivery filtering, which is the most important aspect of the BroadcastChannel settings object.

This tests my desired state, where the BroadcastChannel settings object can be eliminated and we use the relevant settings object instead. (Similar to what whatwg/html#5728 does for MessagePort.)

It appears that unlike MessagePort, where browsers all behave the same (but disagreed with the current spec), here Chrome has the simpler, desirable behavior while Firefox has the per-spec, complicated behavior. Let's see what Safari does when the CI results come in!Safari doesn't support BroadcastChannel

@wpt-pr-bot wpt-pr-bot requested a deployment to wpt-preview-24568 Jul 13, 2020 Pending
@annevk
annevk approved these changes Jul 14, 2020
@domenic domenic merged commit 74b3f3f into master Jul 14, 2020
29 of 30 checks passed
29 of 30 checks passed
detect-deployment detect-deployment
Details
Azure Pipelines Build #20200713.26 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
infrastructure/ tests Community-TC (pull_request)
Details
infrastructure/ tests (Python 3) Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
resources/ tests Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
tools/ integration tests (Python 2) Community-TC (pull_request)
Details
tools/ integration tests (Python 3.6) Community-TC (pull_request)
Details
tools/ integration tests (Python 3.8) Community-TC (pull_request)
Details
tools/ unittests (Python 2) Community-TC (pull_request)
Details
tools/ unittests (Python 3.6) Community-TC (pull_request)
Details
tools/ unittests (Python 3.8) Community-TC (pull_request)
Details
update-built Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@domenic domenic deleted the broadcastchannel-settings-object branch Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.