Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant XrInputSourceArray iterable test #24569

Merged
merged 1 commit into from Jul 11, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jul 10, 2020

XRInputSourceArray_Iterable was failing on chromium, since as a ".html"
and not a ".https.html" file, it was not loaded in a secure context, and
thus WebXr wasn't exposed (and the test API doesn't attempt to polyfill
itself in if navigator.xr doesn't exist). However, on closer inspection,
this is a redundant test case that is already covered by the idlharness.

Fixed: 1104347
Change-Id: Ica4d52578571627e18b9a007e5bb461cf3e34ceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293227
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787443}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

XRInputSourceArray_Iterable was failing on chromium, since as a ".html"
and not a ".https.html" file, it was not loaded in a secure context, and
thus WebXr wasn't exposed (and the test API doesn't attempt to polyfill
itself in if navigator.xr doesn't exist). However, on closer inspection,
this is a redundant test case that is already covered by the idlharness.

Fixed: 1104347
Change-Id: Ica4d52578571627e18b9a007e5bb461cf3e34ceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293227
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787443}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2293227 branch from 9f3bff7 to 1f9766c Jul 11, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 64d6c96 into master Jul 11, 2020
22 checks passed
22 checks passed
Azure Pipelines Build #20200711.2 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2293227 branch Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.