[NativeFS] Keep directory iterator alive while it has pending promises. #24701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 22, 2020
Should hopefully also fix test flakiness where tests seemed to already be running into this. Fixed: 1074123 Change-Id: If57c8d6f622c17d795bc1429f66485cda94befd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313763 Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#791122}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2313763
branch
from
676a931
to
e73575c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should hopefully also fix test flakiness where tests seemed to already
be running into this.
Fixed: 1074123
Change-Id: If57c8d6f622c17d795bc1429f66485cda94befd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313763
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791122}