Parse codecs on VideoEncoder::Configure() #25082
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL front-loads the configuration parsing and codec support
verification into the Configure() method. This means that and invalid
or unsupported config should immediately throw an exception, rather than
being reported in the error callback.
This CL also allows encoders to be re-configured.
Bug: 1116783, 1094166
Change-Id: I88df452cfa2a1b0fcfeb4da6c279665661d7380f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363711
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800277}