Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: Add optionalManufacturerData to options #25351

Merged
merged 1 commit into from Sep 18, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 2, 2020

This change adds the RequestDeviceOptions.optionalManufacturerData
property in order to enable manufacturer data to be protected behind
this permission.

This change also enforces the filtering of service and manufacturer data
from BluetoothAdvertisingEvent objects if services and manufacturer
codes are not included in the filters, optionalServices, and
optionalManufacturerData fields of the RequestDeviceOptions object.

Bug: 1108958
Change-Id: Id7f546e3be5b3c3c26538a69f810a33d2a446fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389243
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808118}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

Loading

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2389243 branch 6 times, most recently from 0a8518e to a85f571 Sep 16, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2389243 branch 2 times, most recently from de42743 to 0437247 Sep 17, 2020
This change adds the RequestDeviceOptions.optionalManufacturerData
property in order to enable manufacturer data to be protected behind
this permission.

This change also enforces the filtering of service and manufacturer data
from BluetoothAdvertisingEvent objects if services and manufacturer
codes are not included in the filters, optionalServices, and
optionalManufacturerData fields of the RequestDeviceOptions object.

Bug: 1108958
Change-Id: Id7f546e3be5b3c3c26538a69f810a33d2a446fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389243
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808118}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2389243 branch from 0437247 to c99cb46 Sep 17, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit b8e402f into master Sep 18, 2020
20 of 22 checks passed
Loading
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2389243 branch Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants