Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idle-detection: Implement requestPermission() method #25399

Merged
merged 1 commit into from Sep 17, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 4, 2020

This change implements a static requestPermission() method on the
IdleDetector interface and switches the API from requiring the
"notifications" permission to the new "idle-detector" permission.

Bug: 878979
Change-Id: If2162f6a1f770544aeb82f98fcc65a76059b7d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359539
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808019}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2359539 branch from 69d6fe7 to 36f5654 Sep 4, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2359539 branch 3 times, most recently from 9cee0d8 to d9b132c Sep 17, 2020
This change implements a static requestPermission() method on the
IdleDetector interface and switches the API from requiring the
"notifications" permission to the new "idle-detector" permission.

Bug: 878979
Change-Id: If2162f6a1f770544aeb82f98fcc65a76059b7d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359539
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808019}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2359539 branch from d9b132c to e7cca41 Sep 17, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 80c4b6a into master Sep 17, 2020
16 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2359539 branch Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants