Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blink][web_tests] document-write tests cleanup #25430

Merged
merged 1 commit into from Sep 16, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 8, 2020

  • Add better assertion failure messages
  • Use better content for document.write

The tests assume that the ignore-destructive-writes counter is only
incremented during the synchronous part of module evaluation (see
whatwg/html#4352 (comment)).

This also fixes document-write/module-delayed.html which accidentally
had wrong test expectations checked in that made it pass.

Bug: 1127215
Bug: 1022182
Bug: v8:9344
Change-Id: I01a75534f7efd0bd8e376dfd049432e52661604d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397696
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807384}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2397696 branch 3 times, most recently from 74ffb9f to 63d9875 Sep 16, 2020
- Add better assertion failure messages
- Use better content for document.write

The tests assume that the ignore-destructive-writes counter is only
incremented during the synchronous part of module evaluation (see
whatwg/html#4352 (comment)).

This also fixes document-write/module-delayed.html which accidentally
had wrong test expectations checked in that made it pass.

Bug: 1127215
Bug: 1022182
Bug: v8:9344
Change-Id: I01a75534f7efd0bd8e376dfd049432e52661604d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397696
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807384}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2397696 branch from 63d9875 to fe5d12b Sep 16, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 05285a5 into master Sep 16, 2020
23 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2397696 branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants