Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: Retire expansion-based implementation of :is and :where #25507

Merged
merged 1 commit into from Sep 18, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 13, 2020

We no longer attempt to expand :is and :where during style sheet loading.

Correct support for these selectors remains to be implemented.

In particular, we need:

  • invalidation - RuleFeatureSet
  • support for empty selector lists
  • error recovery - CSSSelectorParser

Bug: 1127347
Change-Id: I28912cf5cb9b373c423d488b47c20251917329fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405034
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808207}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

Loading

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2405034 branch 4 times, most recently from 0af7e74 to d3026ab Sep 18, 2020
We no longer attempt to expand :is and :where during style sheet loading.

Correct support for these selectors remains to be implemented.

In particular, we need:
- invalidation - RuleFeatureSet
- support for empty selector lists
- error recovery - CSSSelectorParser

Bug: 1127347
Change-Id: I28912cf5cb9b373c423d488b47c20251917329fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405034
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808207}
@Hexcles
Copy link
Member

@Hexcles Hexcles commented Sep 18, 2020

The lint error is fixed in https://crrev.com/c/2417785

Loading

@Hexcles Hexcles merged commit 140c8a2 into master Sep 18, 2020
17 of 19 checks passed
Loading
@Hexcles Hexcles deleted the chromium-export-cl-2405034 branch Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants