Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COOP] access reporting: Add same-origin/cross-origin variant. #25512

Merged
merged 1 commit into from Sep 16, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 14, 2020

Soon, the reports will contains URLS about the other document:

  • openeeURL
  • openerURL
  • otherDocumentURL
  • referrer
  • initialPopupURL

Depending on whether they are same-origin or cross-origin with the
reporter document, they might be reported or not.

This patch add a same-origin/cross-origin variant for every type of
accesses.

Bug: 1090273
Change-Id: Ieeb396f6220877a2a61541cb33a964261e5f4070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407314
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807470}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2407314 branch 2 times, most recently from 7a29653 to d76260f Sep 14, 2020
@ArthurSonzogni
Copy link
Contributor

@ArthurSonzogni ArthurSonzogni commented Sep 16, 2020

Note to wpt sheriff: Please accept this merge.

The chrome stability bot is still failing. This is investigated in:
https://bugs.chromium.org/p/chromium/issues/detail?id=1098413&q=owner%3Ame&can=2

This patch doesn't really modify the crashing test and this patch can be merged.

Soon, the reports will contains URLS about the other document:
- openeeURL
- openerURL
- otherDocumentURL
- referrer
- initialPopupURL

Depending on whether they are same-origin or cross-origin with the
reporter document, they might be reported or not.

This patch add a same-origin/cross-origin variant for every type of
accesses.

Bug: 1090273
Change-Id: Ieeb396f6220877a2a61541cb33a964261e5f4070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407314
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807470}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2407314 branch from d76260f to 9d0ec02 Sep 16, 2020
@Hexcles Hexcles merged commit d751285 into master Sep 16, 2020
20 of 23 checks passed
20 of 23 checks passed
sink-task Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
Azure Pipelines Build #20200916.53 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
update-built Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@Hexcles Hexcles deleted the chromium-export-cl-2407314 branch Sep 16, 2020
@Hexcles
Copy link
Member

@Hexcles Hexcles commented Sep 16, 2020

Thanks for the note, @ArthurSonzogni !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.