Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Document Policy] Isolate font-display wpt tests #25518

Merged
merged 1 commit into from Sep 16, 2020
Merged

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 14, 2020

This CL splits font-display tests into smaller individual tests. The
split has following benefits:

  • Clear obstable for implementation of violation report deduplication
  • Make the tests stricter. Before the test can verify there are
    4 violation reports generated, but cannot tell which 4 cases generate
    violation reports.

Previously there was an attempt on isolating tests into subframes
(https://chromium-review.googlesource.com/c/chromium/src/+/2227863),
but failed due to flaky crash in network cache (crbug.com/1087277).

Bug: 1087277
Change-Id: Ifad35b40d112956fb00fd680b329e539a8762ed9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405916
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Jason Chase <chasej@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807589}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2405916 branch 2 times, most recently from 437c3a5 to f65e1ba Sep 16, 2020
This CL splits font-display tests into smaller individual tests. The
split has following benefits:

- Clear obstable for implementation of violation report deduplication
- Make the tests stricter. Before the test can verify there are
4 violation reports generated, but cannot tell which 4 cases generate
violation reports.

Previously there was an attempt on isolating tests into subframes
(https://chromium-review.googlesource.com/c/chromium/src/+/2227863),
but failed due to flaky crash in network cache (crbug.com/1087277).

Bug: 1087277
Change-Id: Ifad35b40d112956fb00fd680b329e539a8762ed9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405916
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Jason Chase <chasej@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807589}
@Hexcles
Copy link
Member

@Hexcles Hexcles commented Sep 16, 2020

The flaky test /document-policy/font-display/override-to-optional.tentative.html was a simple rename in this CL.

@Hexcles Hexcles merged commit 4a13ee1 into master Sep 16, 2020
20 of 22 checks passed
@Hexcles Hexcles deleted the chromium-export-cl-2405916 branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants