Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webnfc] Remove id, recordType, and mediaType from NDEFScanOptions. #25523

Merged
merged 1 commit into from Sep 16, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 14, 2020

Origin Trial feedback was that webNFC is better without filtering.
NDEFScanOptions now does not need to carry information like recordType
or mediaType as we are not matching them against active watchers
anymore.

Spec changes:
w3c/web-nfc#560
w3c/web-nfc#565

Bug: 520391
Change-Id: I642cff9e72745728f41ad74e803d971a3126ddad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401020
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com>
Cr-Commit-Position: refs/heads/master@{#807597}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

Origin Trial feedback was that webNFC is better without filtering.
NDEFScanOptions now does not need to carry information like recordType
or mediaType as we are not matching them against active watchers
anymore.

Spec changes:
w3c/web-nfc#560
w3c/web-nfc#565

Bug: 520391
Change-Id: I642cff9e72745728f41ad74e803d971a3126ddad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401020
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com>
Cr-Commit-Position: refs/heads/master@{#807597}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2401020 branch from 4a831ec to fcd48db Sep 16, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 559818b into master Sep 16, 2020
27 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2401020 branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants