Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mathml] Disable multicol for MathML layout #25545

Merged
merged 1 commit into from Sep 16, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 15, 2020

This CL disables multicol for MathML, since it has been causing issue
and is not needed for math layout. This is consistent with flexbox,
grid, table or custom layout for example. In particular, this fixes
an assertion failure when multicol is used on MathML token elements.

Bug: 6606, 1128267
Change-Id: I9bb365b7af25e11b994dfc8f2470b3fa4ea2adeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410131
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#807361}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

This CL disables multicol for MathML, since it has been causing issue
and is not needed for math layout. This is consistent with flexbox,
grid, table or custom layout for example. In particular, this fixes
an assertion failure when multicol is used on MathML token elements.

Bug: 6606, 1128267
Change-Id: I9bb365b7af25e11b994dfc8f2470b3fa4ea2adeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410131
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#807361}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2410131 branch from 3c51480 to 5817184 Sep 16, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit cd0ac59 into master Sep 16, 2020
22 checks passed
22 checks passed
Azure Pipelines Build #20200916.20 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2410131 branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.