Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1651569] reduce required SNR to accept KissFFT ConvolverNode implementation #25553

Merged
merged 1 commit into from Sep 16, 2020

Conversation

@moz-wptsync-bot
Copy link
Collaborator

@moz-wptsync-bot moz-wptsync-bot commented Sep 15, 2020

as used in Firefox on some platforms.

minRequiredSNR = 83 permits the quadratic mean of errors to be up to
(10^8.3)^-0.5 ≅ 0.036 * 16384 * 2^-23, implying that most of the samples would
have error significantly less than one ULP for the representation of the peak
of the ramp (16384).

Differential Revision: https://phabricator.services.mozilla.com/D90209

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1651569
gecko-commit: 0194a0d1befc4a1afb4bc4d0cad36ca2b965d994
gecko-reviewers: padenot

as used in Firefox on some platforms.

minRequiredSNR = 83 permits the quadratic mean of errors to be up to
(10^8.3)^-0.5 ≅ 0.036 * 16384 * 2^-23, implying that most of the samples would
have error significantly less than one ULP for the representation of the peak
of the ramp (16384).

Differential Revision: https://phabricator.services.mozilla.com/D90209

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1651569
gecko-commit: 0194a0d1befc4a1afb4bc4d0cad36ca2b965d994
gecko-reviewers: padenot
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Firefox project.

@moz-wptsync-bot moz-wptsync-bot merged commit 66e621e into master Sep 16, 2020
20 checks passed
20 checks passed
Azure Pipelines Build #20200915.91 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
upstream/gecko Landed on mozilla-central
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1651569 branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.