Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XR support to video.rVFC #25555

Merged
merged 1 commit into from Sep 16, 2020
Merged

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 15, 2020

Currently, when we enter an immersive XRSession, window.rAF calls stops,
which means we no longer deliver video.requestVideoFrameCallback calls.

This CL adds video.rVFC support to immersive XRSessions. If we find an
immersive XRSession, we schedule video.rVFC callbacks there instead of
the ScriptedAnimationController (SAC).

There can only be one immersive XRSession. If we don't find a session,
but we find that the XRFrameProvider exists, we request to be notified
when an immersive session start. This allows us to keep callbacks going
if the callbacks were already scheduled in the SAC when starting an
XRSession. Simmilarly, if the session ends when callbacks were pending
in the XRSession, we reschedule ourselves in the SAC.

Bug: 1107578
Change-Id: If0acf9445bb789bc848e0043908fc9b769cc5bdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406522
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807653}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2406522 branch from d84528d to c0a97fe Sep 16, 2020
Currently, when we enter an immersive XRSession, window.rAF calls stops,
which means we no longer deliver video.requestVideoFrameCallback calls.

This CL adds video.rVFC support to immersive XRSessions. If we find an
immersive XRSession, we schedule video.rVFC callbacks there instead of
the ScriptedAnimationController (SAC).

There can only be one immersive XRSession. If we don't find a session,
but we find that the XRFrameProvider exists, we request to be notified
when an immersive session start. This allows us to keep callbacks going
if the callbacks were already scheduled in the SAC when starting an
XRSession. Simmilarly, if the session ends when callbacks were pending
in the XRSession, we reschedule ourselves in the SAC.

Bug: 1107578
Change-Id: If0acf9445bb789bc848e0043908fc9b769cc5bdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406522
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807653}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2406522 branch from c0a97fe to 2ce2cd6 Sep 16, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 54df2c6 into master Sep 16, 2020
22 checks passed
22 checks passed
Azure Pipelines Build #20200916.72 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2406522 branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.