Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "[mathml] Use post.underlineThickness for the default fraction rulethickness" #25565

Merged
merged 1 commit into from Sep 16, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 16, 2020

This was reverted because the frac-1 test is failing on all windows platform
not just Win10.

Original change's description:

Revert "[mathml] Use post.underlineThickness for the default fraction rulethickness"

This reverts commit d01e107517ff5b1da0544be36c5caaf30c27456e.

Reason for revert: <breaks win7 bots - https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29>

Original change's description:

[mathml] Use post.underlineThickness for the default fraction rulethickness

MathML Core currently defines fallback values to use when no MATH table
is available. This CL performs the remaining work to ensure fractions
align with the specification. It also adds WPT test to check these
fraction fallback parameters, although testing them extensively is
difficult.

Bug: 6606, 1058369
Change-Id: Ic916c0c4b925674d526d78989988e57d8735bf4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410384
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807083}

TBR=ikilpatrick@chromium.org,fwang@igalia.com,rbuis@igalia.com

Change-Id: Ia8857539d69bbbafda2be5501ac1b766488be77d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 6606
Bug: 1058369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412750
Reviewed-by: David Bienvenu <davidbienvenu@google.com>
Commit-Queue: David Bienvenu <davidbienvenu@google.com>
Cr-Commit-Position: refs/heads/master@{#807144}

Bug: 6606, 1058369
Change-Id: I2fefb18b84c9604fcd40a013617a51aeadf56602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414029
Reviewed-by: Rob Buis <rbuis@igalia.com>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#807437}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

… rulethickness"

This was reverted because the frac-1 test is failing on all windows platform
not just Win10.

Original change's description:

> Revert "[mathml] Use post.underlineThickness for the default fraction rulethickness"
>
> This reverts commit d01e107517ff5b1da0544be36c5caaf30c27456e.
>
> Reason for revert: <breaks win7 bots - https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29>
>
> Original change's description:
> > [mathml] Use post.underlineThickness for the default fraction rulethickness
> >
> > MathML Core currently defines fallback values to use when no MATH table
> > is available. This CL performs the remaining work to ensure fractions
> > align with the specification. It also adds WPT test to check these
> > fraction fallback parameters, although testing them extensively is
> > difficult.
> >
> > Bug: 6606, 1058369
> > Change-Id: Ic916c0c4b925674d526d78989988e57d8735bf4e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410384
> > Commit-Queue: Frédéric Wang <fwang@igalia.com>
> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#807083}
>
> TBR=ikilpatrick@chromium.org,fwang@igalia.com,rbuis@igalia.com
>
> Change-Id: Ia8857539d69bbbafda2be5501ac1b766488be77d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 6606
> Bug: 1058369
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412750
> Reviewed-by: David Bienvenu <davidbienvenu@google.com>
> Commit-Queue: David Bienvenu <davidbienvenu@google.com>
> Cr-Commit-Position: refs/heads/master@{#807144}

Bug: 6606, 1058369
Change-Id: I2fefb18b84c9604fcd40a013617a51aeadf56602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414029
Reviewed-by: Rob Buis <rbuis@igalia.com>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#807437}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2414029 branch from cea626d to 4ed5038 Sep 16, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 96f4c50 into master Sep 16, 2020
25 checks passed
25 checks passed
Azure Pipelines Build #20200916.45 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
infrastructure/ tests Community-TC (pull_request)
Details
infrastructure/ tests (Python 3) Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
resources/ tests Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2414029 branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.