Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow legacy list item markers inside an NG subtree. #25574

Merged
merged 1 commit into from Sep 17, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 16, 2020

We usually don't encounter NG objects inside a legacy layout subtree,
but this may happen when we have display types that aren't implemented
in the legacy engine, e.g. MathML and custom layout.

This situation should be rare enough, and the combination of list items
and MathML / custom layout doesn't seem like a very common use case. So
just don't go there, and instead keep looking for a better candidate to
place the list item marker inside.

Bug: 1127112
Change-Id: I74c39fae7e5c48d73d5603efca486a05c234a25a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414268
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807788}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

We usually don't encounter NG objects inside a legacy layout subtree,
but this may happen when we have display types that aren't implemented
in the legacy engine, e.g. MathML and custom layout.

This situation should be rare enough, and the combination of list items
and MathML / custom layout doesn't seem like a very common use case. So
just don't go there, and instead keep looking for a better candidate to
place the list item marker inside.

Bug: 1127112
Change-Id: I74c39fae7e5c48d73d5603efca486a05c234a25a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414268
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807788}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2414268 branch from e9b8202 to 27ec1d2 Sep 17, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f52771d into master Sep 17, 2020
22 checks passed
22 checks passed
Azure Pipelines Build #20200917.20 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2414268 branch Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.