Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1518999] Update ContentfulPaint algorithm to follow the spec #25578

Closed
wants to merge 1 commit into from

Conversation

@moz-wptsync-bot
Copy link
Collaborator

@moz-wptsync-bot moz-wptsync-bot commented Sep 16, 2020

This patch includes a couple of changes.

  1. Notify contentful paint only during refresh driver ticks.
  2. Not only the root document, sub document should also have their own
    contentful paint entry.
  3. Consider invisible text as contentful as well.

Differential Revision: https://phabricator.services.mozilla.com/D89498

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1518999
gecko-commit: 5a6cea5fd344070dd197d368bfa4f92dfb31313e
gecko-reviewers: emilio

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Firefox project.

@jgraham
Copy link
Contributor

@jgraham jgraham commented Sep 23, 2020

@sefeng211 This seems to be intermittent in Chrome. Is that expected and/or can we fix the test to not be intermittent?

@sefeng211
Copy link
Contributor

@sefeng211 sefeng211 commented Sep 23, 2020

@jgraham Thanks, this is not expected and I'll need to take a look.

Since the corresponding Gecko patches have backed out, shouldn't this PR get closed? I'll probably need to fix the test and then reland the Gecko part. Is it okay if we leave it open?

@jgraham jgraham closed this Oct 6, 2020
This patch includes a couple of changes.
1) Notify contentful paint only during refresh driver ticks.
2) Not only the root document, sub document should also have their own
   contentful paint entry.
3) Consider invisible text as contentful as well.

Differential Revision: https://phabricator.services.mozilla.com/D89498

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1518999
gecko-commit: 8ac8461d7bd7c0345302969152072ae5204be768
gecko-reviewers: emilio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.