Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fieldset NG: Fix hit-testing for the rendered LEGEND, take 2 #25580

Merged
merged 1 commit into from Sep 17, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 17, 2020

crrev.com/806924 missed to add |accumulated_offset| to the LEGEND's
offset. So hit-testing didn't work well if the FIELDSET was placed far
from the origin.

Bug: 1127743
Change-Id: I16c80b8074f9082516a6ecd5bb82407bbe7d3551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413681
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807797}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

crrev.com/806924 missed to add |accumulated_offset| to the LEGEND's
offset.  So hit-testing didn't work well if the FIELDSET was placed far
from the origin.

Bug: 1127743
Change-Id: I16c80b8074f9082516a6ecd5bb82407bbe7d3551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413681
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807797}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2413681 branch from 1fa6406 to 7dcd69a Sep 17, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 7efc877 into master Sep 17, 2020
23 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2413681 branch Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants