Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html/coep/cross-origin-isolated-permission.https.html #25584

Merged
merged 4 commits into from Sep 24, 2020

Conversation

@yutakahirano
Copy link
Contributor

@yutakahirano yutakahirano commented Sep 17, 2020

  • Add an intermediary frame to actually test Permissions-Policy.
  • Unquote self.
  • Use () instead of "none".

Fixes whatwg/html#5888.

 - Add an intermediary frame to actually test Permissions-Policy.
 - Unquote `self`.
 - Use `()` instead of `"none"`.

Fixes whatwg/html#5888.
@yutakahirano
Copy link
Contributor Author

@yutakahirano yutakahirano commented Sep 17, 2020

@clelland @annevk can you take a look?

Copy link
Member

@mikewest mikewest left a comment

LGTM.

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-25584 Sep 17, 2020 Inactive
@yutakahirano
Copy link
Contributor Author

@yutakahirano yutakahirano commented Sep 23, 2020

@clelland @annevk are you fine with this change? I'll merge this tomorrow if there are no further comments.

@yutakahirano yutakahirano merged commit 450ac78 into master Sep 24, 2020
21 checks passed
@yutakahirano yutakahirano deleted the yhirano/cross-origin-isolated-wpt-fix branch Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment