Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mathml] Only perform special handling of <mo>s when they are text-only #25590

Merged
merged 1 commit into from Sep 17, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 17, 2020

MathML Core says special properties of operators happen when the
corresponding <mo> elements contain text content only [1]. However,
Blink currently just reads the element's textContent() without checking
whether it contains non-text children. This CL fixes that behavior and
also adds a WPT test to verify correct lspace/rspace (including after
dynamic change of the <mo> content).

[1] https://mathml-refresh.github.io/mathml-core/#dfn-algorithm-for-determining-the-properties-of-an-embellished-operator

Bug: 6606
Change-Id: Iab0e3309bf03167889e4a7161fd053a4a9744908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414282
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#808089}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2414282 branch 2 times, most recently from 885f2e9 to 9c0820e Sep 17, 2020
MathML Core says special properties of operators happen when the
corresponding <mo> elements contain text content only [1]. However,
Blink currently just reads the element's textContent() without checking
whether it contains non-text children. This CL fixes that behavior and
also adds a WPT test to verify correct lspace/rspace (including after
dynamic change of the <mo> content).

[1] https://mathml-refresh.github.io/mathml-core/#dfn-algorithm-for-determining-the-properties-of-an-embellished-operator

Bug: 6606
Change-Id: Iab0e3309bf03167889e4a7161fd053a4a9744908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414282
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#808089}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2414282 branch from 9c0820e to 53723cb Sep 17, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 43454a8 into master Sep 17, 2020
19 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2414282 branch Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants